Podman final #13
Open
Podman final #13
+1,717
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Install podman
hexfusion
commented
Jun 24, 2023
| WaitForStatus(ctx context.Context, id string, status define.ContainerStatus) (int32, error) | ||
| } | ||
|
|
||
| type Client struct{} |
There was a problem hiding this comment.
client isn't really even needed this can all be removed or maybe we keep Stop/Start
hexfusion
commented
Jun 24, 2023
| return status, stopper, nil | ||
| } | ||
|
|
||
| func generateRandomString(n int) (string, error) { |
hexfusion
commented
Jun 24, 2023
| // if strings.HasSuffix(name, podSuffix) { | ||
| // isPod = true | ||
| // name = strings.TrimSuffix(name, podSuffix) | ||
| // } |
There was a problem hiding this comment.
ANR expected plugin/<VMID> executable
hexfusion
commented
Jun 26, 2023
| return nil, nil, fmt.Errorf("failed to marshall pod: %w", err) | ||
| } | ||
|
|
||
| pctx, err := bindings.NewConnection(context.Background(), socket) |
There was a problem hiding this comment.
this should take parent ctx
| return nil, nil, fmt.Errorf("failed to create podman conn: %w", err) | ||
| } | ||
|
|
||
| _, err = kube.PlayWithBody(pctx, bytes.NewReader(podBytes), &kube.PlayOptions{}) |
There was a problem hiding this comment.
would be nice to dump the report returned here to logs.
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
works
TODO: right now we make 1 pod per instance of the VM It would make more sense that all the containers for a VM were in the same pod
How this works
How this was tested