fix: use export function or export const instead of exports
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tommy351 @NoahDragon |
yoshinorin
changed the title
export function or export const instead of exportsexport function or export const instead of exports
yoshinorin
force-pushed
the
fix/ts-export
branch
from
479b6b1
to
c988919
Compare
tomap
approved these changes
Sep 11, 2022
SukkaW
approved these changes
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not familiar with TS. But, my understanding we have to use
export functionorexport constinstead ofexports.xxxx. Actually, the currentfs.d.tswhich is generated when runnpm run builddoes not contain function definitions.Thank you :)