Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/appveyor error #5

Merged
merged 4 commits into from
Jul 10, 2017
Merged

Fix/appveyor error #5

merged 4 commits into from
Jul 10, 2017

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 8, 2017

Finally fixed broken test.

Added package-lock.json as routine. If we decide not to add package-lock, I can rebase that.

@JLHwung JLHwung requested a review from NoahDragon July 8, 2017 09:36
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.607% when pulling f3245cc on fix/appveyor-error into 697c379 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.607% when pulling f3245cc on fix/appveyor-error into 697c379 on master.

@NoahDragon
Copy link
Member

Thank you very much, this issue buzzed Hexo CI for a long while.

@NoahDragon NoahDragon merged commit 9af3450 into master Jul 10, 2017
@NoahDragon NoahDragon deleted the fix/appveyor-error branch July 10, 2017 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahDragon NoahDragon Awaiting requested review from NoahDragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JLHwung @coveralls @NoahDragon