Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: utilize full_url_for() #149

Merged
merged 2 commits into from
Jul 2, 2020
Merged

refactor: utilize full_url_for() #149

merged 2 commits into from
Jul 2, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Jul 1, 2020

url + post.image is problematic because post.image may have a slash prefix and cause the result to have double slash.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8a0db16 on curbengh:url-for into 95cc7cc on hexojs:master.

@curbengh curbengh merged commit fa1f04a into hexojs:master Jul 2, 2020
@curbengh curbengh deleted the url-for branch July 2, 2020 00:27
@curbengh curbengh mentioned this pull request Jul 2, 2020
Open
curbengh pushed a commit to curbengh/curbengh.github.io that referenced this pull request Aug 21, 2020
refactor: utilise full_url_for()
c422ff9 
- hexojs/hexo-generator-feed#149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @SukkaW