WIP fix(IDN): uriencode root value #88

curbengh · 2019-08-18T08:40:07Z

The current approach does not encode the root value, this PR fixes that.
Similar to hexojs/hexo-generator-sitemap#66

coveralls · 2019-08-18T08:41:39Z

Coverage remained the same at 100.0% when pulling 949f9ff on curbengh:idn-punycode into af8a1b6 on hexojs:master.

curbengh · 2019-08-22T14:37:27Z

post.permalink is empty throughout the unit test, not sure how to fix that.

This PR works in a test blog.

curbengh · 2019-09-02T05:13:01Z

tomap · 2019-09-07T06:55:34Z

curbengh · 2019-09-08T06:00:37Z

Superseded by #93

curbengh force-pushed the idn-punycode branch from 5905329 to 8129283 Compare August 22, 2019 14:28

curbengh added 2 commits August 23, 2019 00:00

fix(IDN): uriencode root value

aa2aea5

test: add test for root value

bc66c83

curbengh force-pushed the idn-punycode branch from 8129283 to bc66c83 Compare August 22, 2019 14:31

curbengh added 4 commits August 23, 2019 09:25

test: use describe()

d63c6ff

test: simpler approach

a292055

fix: remove unused config

376b435

refactor: access url methods directly

949f9ff

curbengh mentioned this pull request Aug 24, 2019

fix(open_graph): percent-encode url, not html escape hexojs/hexo#3686

Merged

2 tasks

curbengh requested a review from tomap August 24, 2019 08:46

curbengh mentioned this pull request Sep 2, 2019

feat: add encodeURL() hexojs/hexo-util#77

Merged

curbengh changed the title ~~fix(IDN): uriencode root value~~ WIP fix(IDN): uriencode root value Sep 2, 2019

curbengh mentioned this pull request Sep 8, 2019

fix(IDN): uriencode root value #93

Merged

curbengh closed this Sep 8, 2019

curbengh deleted the idn-punycode branch September 8, 2019 06:00

Provide feedback