Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop old interface and fix test code #58

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

uiolee
Copy link
Member

@uiolee uiolee commented Sep 2, 2023

what does it do

  • drop old configuration, refact the code
  • improve test code
  • add ci for lint and test
  • update docs
  • add eslint, fix gitignore, update packages.

if it is merged, close #55 and close #57

know issue

  • the coverage didn't reach 100%. (test/renderer.test.js#L40)
    one item of test didn't work in ci(ubuntu),
    but work in macOS and Windows also my WSL(ubuntu).
    I haven't found the reason yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant