-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 1.0.0 following 1 year of changes #57
Conversation
to show that it is stable
+1 But, IMHO a package version up should just before publish. |
Before we do that, I'm wondering if this file
It was published in the previous version |
https://www.npmjs.com/package/hexo-util/v/1.0.0-rc1 |
I think the purpose of not publishing it, instead it is dynamically generated is because new version highlight.js might support new languages. Meaning it is possible that highlight.js supports more than the published version highlight_alias.json. |
Ok, if you're sure, I'll publish next RC without it |
highlight_alias.json is not generated when I "hexo-util": "hexojs/hexo-util", publish next RC without it, I'll test it. |
I just published RC2 @curbengh I published without highlight_alias.json. |
Did you include #67 in RC2? Update hexojs/hexo#3646 to include RC2 too. |
I just found out the statement is actually outdated. The postinstall step has been replaced by #28 so the build runs during npm publish, not npm install (unless it is executed in ./node_modules/hexo-util). highlight_alias.json indeed needs to be published, but still remain gitignored. If I "hexo-util": "hexojs/hexo-util" somehow it works, despite there is no highlight_alias.json in the repo. The highlight_alias.json does get generated in ./node_modules/hexo-utl. My guess is highlight_alias.json is generated on client machine when installed from a git repo, but not generated when installed from npmjs.com. I'll have more testing on RC2 to confirm this. PR fix #69 |
I just published RC3: https://www.npmjs.com/package/hexo-util/v/1.0.0-rc3 The tgz comes from my way of creating the npm package: // to check the content
npm publish --dry-run
// to produce the package as a .tgz
npm pack
// to publish the package
npm publish hexo-util-1.0.0-rc3.tgz -tag next |
I see, I usually just
|
I dropped the *.tgz from gitignore and will use your command lines |
hexojs/hexo#3646 => tests look good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
versioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use npm version
instead of pull requests to manually bump the versions.
We create PR to notify team members. |
v1 published |
to show that it is stable