-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable Nunjucks when the renderer spcify that #2593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please keep the old promising style?
promise(
some code
).then(
antoher code
)
instead of
promise(
some code
)
.then(
another code
)
This will make the change comparison more clearly.
@NoahDragon Hold on. |
@NoahDragon Finish. |
Thank for the PR. IMO, give this decision to renderers is better than to the users. #2478 |
I'm thinking extend this function to post front matters. Instead of site-wide configuration variable, each post can disable Nunjucks when specified. Do you think this will be feasible and compatible with your change? |
Sorry, could you please provide an example of how would a renderer use this feature? |
@9662 |
This PR adds Nunjucks disabling if the renderer claim that it can handle “tags” on its own.
Currently it is not active (i.e., Nunjucks would work) for all existing renderers.