Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ignore dirs from processing that are not required. #2631

Merged
merged 2 commits into from
Jul 4, 2017
Merged

feat: Ignore dirs from processing that are not required. #2631

merged 2 commits into from
Jul 4, 2017

Conversation

bhaskarmelkani
Copy link
Member

@bhaskarmelkani bhaskarmelkani commented Jul 3, 2017 •
edited
Loading

This is a proposal for the issue #2632

Example _config.yml entry.

ignore: ['**/themes/**/node_modules/**', '**/themes/**/node_modules', '**/themes/**/.git', '**/themes/**/.git/**']

TODO:

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Jul 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 97.049% when pulling 409ca8d on bhaskarmelkani:master into 5a28258 on hexojs:master.

@bhaskarmelkani bhaskarmelkani reopened this Jul 3, 2017
@bhaskarmelkani bhaskarmelkani mentioned this pull request Jul 3, 2017
Closed
@coveralls
Copy link

coveralls commented Jul 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 97.049% when pulling 409ca8d on bhaskarmelkani:master into 5a28258 on hexojs:master.

@bhaskarmelkani bhaskarmelkani changed the title feat: Ignore files from processing feat: Ignore files from processing that are not requires. Jul 3, 2017
@bhaskarmelkani bhaskarmelkani changed the title feat: Ignore files from processing that are not requires. feat: Ignore files from processing that are not required. Jul 3, 2017
@coveralls
Copy link

coveralls commented Jul 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 97.049% when pulling 8844a9e on bhaskarmelkani:master into 5a28258 on hexojs:master.

@NoahDragon
Copy link
Member

Thanks for the PR. Could you please fix the travis errors and add test cases?

@bhaskarmelkani
Copy link
Member Author

Hey
Sure, will do.

@coveralls
Copy link

coveralls commented Jul 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 97.226% when pulling 83e199f on bhaskarmelkani:master into 5a28258 on hexojs:master.

@coveralls
Copy link

coveralls commented Jul 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 97.175% when pulling 0e74fbf on bhaskarmelkani:master into 5a28258 on hexojs:master.

@coveralls
Copy link

coveralls commented Jul 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 97.15% when pulling 60d0840 on bhaskarmelkani:master into 5a28258 on hexojs:master.

@bhaskarmelkani
Copy link
Member Author

bhaskarmelkani commented Jul 4, 2017 •
edited
Loading

@NoahDragon Hey I have added the tests and fixed issue with travis CI. But appveyor is having some trouble and its not related to me.

It breaks for a blank with no changes.PR#2633.

NoahDragon
NoahDragon approved these changes Jul 4, 2017
View reviewed changes
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhaskarmelkani
Copy link
Member Author

Awesome :)

@bhaskarmelkani
Copy link
Member Author

@NoahDragon When we can see that merged and released ? Thanks

@NoahDragon
Copy link
Member

@bhaskarmelkani Normally within a week, the new changes will be in the npm package.

@NoahDragon NoahDragon merged commit b7ab752 into hexojs:master Jul 4, 2017
@bhaskarmelkani
Copy link
Member Author

Awesome, thanks :)

@darekkay darekkay mentioned this pull request Nov 18, 2017
Closed
@bhaskarmelkani bhaskarmelkani changed the title feat: Ignore files from processing that are not required. feat: Ignore dirs from processing that are not required. Nov 20, 2017
This was referenced Jan 10, 2019
Closed
Closed
This was referenced Sep 18, 2019
Closed
Closed
@seaoak seaoak mentioned this pull request Oct 24, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahDragon NoahDragon NoahDragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhaskarmelkani @coveralls @NoahDragon