Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove \u180e on excerpt test case #2729

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Conversation

JLHwung
Copy link
Collaborator

@JLHwung JLHwung commented Aug 25, 2017

MVS is removed from whitespace since Unicode 8.0.0, see http://www.unicode.org/L2/L2013/13004-vowel-sep-change.pdf

ES2016 uses Unicode 8.0.0 thus the test fails on node.js 8.4.0

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • [-] Add test cases for the changes.
  • Passed the CI test.

Blocks #2728.

MVS is removed from whitespace since Unicode 8.0.0, see http://www.unicode.org/L2/L2013/13004-vowel-sep-change.pdf

ES2016 uses Unicode 8.0.0 thus the test fails on node.js 8.4.0
@coveralls
Copy link

coveralls commented Aug 25, 2017

Coverage Status

Coverage remained the same at 97.154% when pulling faf452e on whitespace-update into 6c0fbd0 on master.

Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NoahDragon NoahDragon merged commit 5a47abc into master Aug 25, 2017
@JLHwung JLHwung deleted the whitespace-update branch August 25, 2017 14:24
@NoahDragon NoahDragon mentioned this pull request Aug 29, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants