fix: Add defaults to console command generate #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelled bug as tests were not in sync with code. |
JLHwung
requested changes
Nov 21, 2017
| @@ -20,7 +20,6 @@ describe('generate', () => { | |||
| afterEach(() => fs.rmdir(hexo.base_dir)); | |||
|
|
|||
| function testGenerate(options) { | |||
| options = options || {}; | |||
There was a problem hiding this comment.
%s/generate\(\{\}\)/generate\(\)/g.
There was a problem hiding this comment.
Oh yeah, makes sense. 👍
bhaskarmelkani
force-pushed
the
fix/generator-defaults
branch
from
87412bf
to
efb99f4
Compare
JLHwung
approved these changes
Nov 22, 2017
|
Thank you so much for you contribution. Hexo can't be rock without contributors like you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defaults to console command
generate.Related to #Issue