Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(post-asset): strip /\.html?$/ extensions on permalink #2881

Merged
merged 1 commit into from
Dec 4, 2017
Merged

fix(post-asset): strip /\.html?$/ extensions on permalink #2881

merged 1 commit into from
Dec 4, 2017

Conversation

JLHwung
Copy link
Collaborator

@JLHwung JLHwung commented Dec 4, 2017

Fixes #2134
Closes #2551
Closes #2504

cc @Alex1990 @changyuheng

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Dec 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 97.226% when pulling 971c56e on fix-2134 into 08a9b5f on master.

@coveralls
Copy link

coveralls commented Dec 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 97.226% when pulling 597bf1b on fix-2134 into 08a9b5f on master.

@coveralls
Copy link

coveralls commented Dec 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 97.226% when pulling 91d6110 on fix-2134 into 08a9b5f on master.

@hexojs hexojs deleted a comment from coveralls Dec 4, 2017
NoahDragon
NoahDragon approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for looking into this bug. I already forgot I have committed to fix it...

@NoahDragon NoahDragon merged commit 284c1b9 into master Dec 4, 2017
@NoahDragon NoahDragon deleted the fix-2134 branch December 4, 2017 22:22
@yoshinorin yoshinorin mentioned this pull request Feb 6, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahDragon NoahDragon NoahDragon approved these changes

@leesei leesei Awaiting requested review from leesei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JLHwung @coveralls @NoahDragon