Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): specify files to shrink package size #3378

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

JLHwung
Copy link
Collaborator

@JLHwung JLHwung commented Dec 1, 2018

Specified size so that we will not publish package lock files to npm.

Before: 86.2 kB (308.5 kB)
After: 54.2 kB (199.5 kB)

@JLHwung JLHwung requested a review from tcrowe December 1, 2018 14:30
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.254% when pulling 2f0c28e on shrink-package-size into e16f19a on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.254% when pulling 2f0c28e on shrink-package-size into e16f19a on master.

@tomap
Copy link
Contributor

tomap commented Dec 2, 2018

You can see the content of the current package: https://unpkg.com/hexo@3.8.0/ it already includes only what is necessary
not sure your MR is useful

@JLHwung
Copy link
Collaborator Author

JLHwung commented Dec 6, 2018

@tomap Sorry for the late reply. The reason why I prefer to specify dist instead of .npmignore is that we are pretty sure dist is the root directory of our build artifacts and it should be complete and autonomous. If we do not specify files in the package.json, there will be, from time to time, maintainer have to remember to add any yarn.lock, package-lock.json, .foorc or bar.config.js files to the .npmignore so that the package size is optimal.

It is not easy and straightforward to have our maintainers remembering these process, especially when we are adding more and more dev infrastrurcture configurations.

@tomap
Copy link
Contributor

tomap commented Dec 6, 2018

@JLHwung I agree, your way is better

@yoshinorin
Copy link
Member

It seems good and I think this PR can merge to master branch.
But Appveyor were failed. Is it possible to re-build ? I tried to rebuild, but seems impossible using by manually build.

@tomap
Copy link
Contributor

tomap commented Dec 12, 2018

If you push a new commit, it will trigger a new build

@yoshinorin
Copy link
Member

Hmm...
Probably, the reason of failed the Appveyor that not this change.

OK, I do merge this PR.

@yoshinorin yoshinorin merged commit ccce9d6 into master Dec 12, 2018
@yoshinorin yoshinorin deleted the shrink-package-size branch December 12, 2018 14:50
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants