Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): replace deprecated istanbul with nyc #3570

Merged
merged 3 commits into from
Jun 6, 2019
Merged

chore(deps-dev): replace deprecated istanbul with nyc #3570

merged 3 commits into from
Jun 6, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Jun 2, 2019 •
edited
Loading

What does it do?

istanbul has been deprecated (last published 3 years ago). It is replaced by nyc instead.

Current version (as of v14.1.1) still supports Node 6.

How to test

git clone -b nyc https://github.com/weyusi/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Passed the CI test.

yoshinorin
yoshinorin requested changes Jun 4, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea :)
But, coverage report doesn't send to coveralls. Maybe something wrong...

@coveralls
Copy link

coveralls commented Jun 5, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 97.148% when pulling 1e563b7 on weyusi:nyc into a83280f on hexojs:master.

@curbengh
Copy link
Contributor Author

curbengh commented Jun 5, 2019

Added integration of nyc with coveralls.
ref: https://istanbul.js.org/docs/tutorials/mocha/

@curbengh curbengh mentioned this pull request Jun 5, 2019
Merged
@curbengh curbengh changed the title chore(deps): replace deprecated istanbul with nyc chore(deps-dev): replace deprecated istanbul with nyc Jun 5, 2019
yoshinorin
yoshinorin approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yoshinorin yoshinorin merged commit 61781ad into hexojs:master Jun 6, 2019
@yoshinorin yoshinorin mentioned this pull request Jun 6, 2019
Merged
@curbengh curbengh deleted the nyc branch June 7, 2019 04:13
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@curbengh
chore(deps-dev): replace deprecated istanbul with nyc (hexojs#3570)
272df4c 
* chore(deps): replace deprecated istanbul with nyc
* test: integrate nyc with coveralls
* chore: ignore nyc output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curbengh @coveralls @yoshinorin @weyusi