Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1 #3606

Merged
merged 2 commits into from
Jul 6, 2019
Merged

chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1 #3606

merged 2 commits into from
Jul 6, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Jul 1, 2019

What does it do?

Update eslint to v6.
eslint@6 enable no-prototype-builtins rule by default, which entails the refactors.

How to test

git clone -b eslint-prototype https://github.com/weyusi/hexo.git
cd hexo
npm install
npm test

Pull request tasks

@curbengh curbengh added this to the v4.0.0 milestone Jul 1, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.148% when pulling cebcbf4 on weyusi:eslint-prototype into fe107a1 on hexojs:master.

@curbengh curbengh changed the title Eslint prototype chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1 Jul 1, 2019
yoshinorin
yoshinorin approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yoshinorin yoshinorin merged commit c2e4672 into hexojs:master Jul 6, 2019
@curbengh curbengh deleted the eslint-prototype branch July 6, 2019 05:45
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@curbengh
chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1 (hex…
10fbdbd 
…ojs#3606)

* chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1

* refactor: call hasOwnProperty from Object.prototype

https://eslint.org/docs/6.0.0/rules/no-prototype-builtins
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@curbengh @coveralls @yoshinorin @weyusi