Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prism highlight support #4119

Merged
merged 10 commits into from
Jun 8, 2020
Merged

feat: add prism highlight support #4119

merged 10 commits into from
Jun 8, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Feb 9, 2020

What does it do?

Related: #1036 & #4010

How to test

git clone -b feat-prism https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested review from seaoak, curbengh and a team February 9, 2020 12:33
tomap
tomap previously approved these changes Feb 23, 2020
View reviewed changes
@tomap
Copy link
Contributor

tomap commented Feb 23, 2020

Maybe you can have a look at the duplicate code issue mentionned by codeclimate?

@SukkaW SukkaW requested a review from tomap March 10, 2020 08:43
@stevenjoezhang stevenjoezhang mentioned this pull request Mar 24, 2020
Closed
@stevenjoezhang stevenjoezhang mentioned this pull request Apr 1, 2020
Merged
2 tasks
@stevenjoezhang stevenjoezhang linked an issue Apr 22, 2020 that may be closed by this pull request
why jsx syntax doesn't highlighted in hexo #2720
Closed
@coveralls
Copy link

coveralls commented Apr 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 97.75% when pulling c3e19f0 on SukkaW:feat-prism into c51b87e on hexojs:master.

@SukkaW
Copy link
Member Author

SukkaW commented Apr 26, 2020 •
edited
Loading

Maybe you can have a look at the duplicate code issue mentionned by codeclimate?

@tomap

Duplicated code are merged and removed.

@stevenjoezhang stevenjoezhang linked an issue May 14, 2020 that may be closed by this pull request
Highlight.js is slow #1036
Closed
@SukkaW
Copy link
Member Author

SukkaW commented Jun 5, 2020 •
edited
Loading

I just HATE REBASING MY PR OVER AND OVER AGAIN.

@seaoak @tomap @segayuu @jiangtj @stevenjoezhang @curbengh @yoshinorin

SOMEBODY PLEASE, REVIEW MY PR (for gods sake).

@SukkaW SukkaW requested a review from yoshinorin June 5, 2020 06:12
@stevenjoezhang stevenjoezhang linked an issue Jun 8, 2020 that may be closed by this pull request
Feature request: support other syntax highlight libraries #4010
Closed
@SukkaW SukkaW merged commit f36e29c into hexojs:master Jun 8, 2020
@NoahDragon NoahDragon mentioned this pull request Jun 8, 2020
Open
53 tasks
@stevenjoezhang stevenjoezhang mentioned this pull request Jun 8, 2020
Merged
@SukkaW SukkaW mentioned this pull request Jul 16, 2020
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segayuu segayuu segayuu approved these changes

@seaoak seaoak Awaiting requested review from seaoak

@curbengh curbengh Awaiting requested review from curbengh

@tomap tomap Awaiting requested review from tomap

@jiangtj jiangtj Awaiting requested review from jiangtj

@stevenjoezhang stevenjoezhang Awaiting requested review from stevenjoezhang

@yoshinorin yoshinorin Awaiting requested review from yoshinorin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@SukkaW @tomap @coveralls @segayuu