Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove lodash from global variable #4266

Merged
merged 1 commit into from
May 20, 2020
Merged

refactor: remove lodash from global variable #4266

merged 1 commit into from
May 20, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Apr 25, 2020

What does it do?

How to test

git clone -b remove-lodash-from-global-variable https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 97.756% when pulling 71a554c on SukkaW:remove-lodash-from-global into 6d29793 on hexojs:master.

@SukkaW SukkaW merged commit 378c22b into hexojs:master May 20, 2020
@SukkaW SukkaW mentioned this pull request Jun 2, 2020
Closed
@SukkaW SukkaW mentioned this pull request Jul 16, 2020
Merged
22 tasks
zklhp added a commit to zklhp/maupassant-hexo that referenced this pull request Jul 30, 2020
@zklhp
Use native JavaScript over Lodash
2b94695 
Since Hexo 5.0.0 removes Lodash from global variable. See hexojs/hexo#4266
@zklhp zklhp mentioned this pull request Jul 30, 2020
Merged
@XiaoPika XiaoPika mentioned this pull request Nov 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@yoshinorin yoshinorin yoshinorin approved these changes

@segayuu segayuu segayuu approved these changes

@seaoak seaoak Awaiting requested review from seaoak

@curbengh curbengh Awaiting requested review from curbengh

Assignees
No one assigned
Labels
Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SukkaW @coveralls @segayuu @yoshinorin @stevenjoezhang