fix(post): swig tag inside post #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fixes for #3543 is not included. Maybe I will open an another PR. |
SukkaW
commented
Jun 10, 2020
| @@ -669,13 +669,13 @@ describe('Post', () => { | |||
| }); | |||
|
|
|||
| it('render() - recover escaped nunjucks blocks which is html escaped', () => { | |||
| const content = '`{% raw %}{{ test }}{% endraw %}`'; | |||
| const content = '`{% raw %}{{ test }}{% endraw %}`, {%raw%}{{ test }}{%endraw%}'; | |||
There was a problem hiding this comment.
The alter of the test case here is to test my newly added rSwigRawFullBlock
stevenjoezhang
approved these changes
Jun 11, 2020
| engine: 'markdown' | ||
| }); | ||
|
|
||
| data.content.trim().should.eql('<p>In Go’s templates, blocks look like this: <code>&#123;&#123;block "template name" .&#125;&#125; (content) &#123;&#123;end&#125;&#125;</code>.</p>'); |
There was a problem hiding this comment.
It seems that &#123; is escaped twice and it's displayed as { instead of { in the browser. Is this expected?
There was a problem hiding this comment.
I will update the test case using escapeHTML to make it clearer.
There was a problem hiding this comment.
The marked.js will escape code by default, thus caused double escape.
2 tasks
22 tasks
curbengh
added a commit
to curbengh/hexo-site
that referenced
this pull request
Aug 22, 2020
- to include hexojs/hexo#4352 fix
Merged
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The PR fixes #3259, #3346 & #3346 (comment)
How to test
Screenshots
Pull request tasks