Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#4317): non-greedy regexp for tag escape #4358

Merged
merged 2 commits into from
Jun 15, 2020
Merged

fix(#4317): non-greedy regexp for tag escape #4358

merged 2 commits into from
Jun 15, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jun 15, 2020

What does it do?

Similar to #4161, use non-greedy regexp. See #4161 for more details.

This PR closes #4317.

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested review from stevenjoezhang and a team June 15, 2020 12:48
@SukkaW SukkaW mentioned this pull request Jun 15, 2020
Closed
5 tasks
stevenjoezhang
stevenjoezhang previously approved these changes Jun 15, 2020
View reviewed changes
@SukkaW
Copy link
Member Author

SukkaW commented Jun 15, 2020 •
edited
Loading

The fix is verified by #4317 (comment)

@SukkaW SukkaW merged commit edef5c2 into hexojs:master Jun 15, 2020
@SukkaW SukkaW added this to the 5.0.0 milestone Jun 15, 2020
@SukkaW SukkaW mentioned this pull request Jul 25, 2020
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

if set hljs to true in hexo config, it will cause some Tag Plugins no rendering
2 participants
@SukkaW @stevenjoezhang