Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(meta_generator): no longer ignore empty <head> #4442

Merged
merged 1 commit into from
Jul 25, 2020
Merged

refactor(meta_generator): no longer ignore empty <head> #4442

merged 1 commit into from
Jul 25, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jul 25, 2020 •
edited
Loading

What does it do?

Ignoring empty <head> tag is firstly introduced in #3315, in which cheerio@1 will automatically append <html><head><body>. After #3677, cheerio has been dropped from dependencies. And cheerio in devDependencies has been pinned at 0.22.0 as well. So I just assume there will be no empty <head> tag any more.

The PR removes empty <head> detection which results in less generation time.

How to test

git clone -b meta-generator-empty https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested review from yoshinorin, curbengh and a team July 25, 2020 08:44
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.233% when pulling 212afd8 on SukkaW:meta-generator-empty into 9076422 on hexojs:master.

@SukkaW SukkaW mentioned this pull request Jul 25, 2020
Merged
22 tasks
@SukkaW SukkaW merged commit 49ff2b2 into hexojs:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curbengh curbengh curbengh approved these changes

@yoshinorin yoshinorin Awaiting requested review from yoshinorin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukkaW @coveralls @curbengh