feat(helper/is): add is_home_first_page() helper
#5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b is-index https://github.com/renbaoshuo/hexo.git
cd hexo
npm install
npm test |
SukkaW
reviewed
Jun 23, 2022
renbaoshuo
changed the title
is_index() helperis_home_first_page() helper
SukkaW
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Added a new helper called
is_index()is_home_first_page(). This helper will detect whether the page is a page generated by hexo-generator-index and the page number is 1.In fact, I thought the functions ofis_home()andis_index()should be swapped, but that would break the existing page, so I created a new helper.Screenshots
None.
Pull request tasks