Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bind hexo context to helper function callback #5555

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: bind hexo context to helper function callback #5555

wants to merge 7 commits into from

Conversation

dimaslanjaka
Copy link
Contributor

@dimaslanjaka dimaslanjaka commented Oct 5, 2024 •
edited
Loading

What does it do?

  • Apply hexo context for this callback, useful for plugin written with typescript. Sample
  • Fix some missmatch type (fail compile fixed)

Screenshots

image
image

based on https://hexo.io/api/helper#How-do-I-use-another-registered-helper-in-my-custom-helper
image

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

How to test

git clone -b fix-helper-context https://github.com/dimaslanjaka/hexo.git
cd hexo
npm install
npm test

@dimaslanjaka
Copy link
Contributor Author

dimaslanjaka commented Oct 5, 2024 •
edited
Loading

@uiolee @SukkaW review pls, any miss/wrong ?

SukkaW
SukkaW requested changes Oct 5, 2024
View reviewed changes
lib/plugins/filter/template_locals/i18n.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimaslanjaka @SukkaW @uiolee