fix: wrong type for StoreFunction of helper #5568
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The
require
actually leads to the imported type becomingany
, which will cause some return value of helpers that actually returnboolean
or complex types to be incorrectly threated asstring
, yet cannot be detected by eslint, for example here:hexo/lib/plugins/helper/index.ts
Lines 31 to 41 in 492debf
and here:
hexo/lib/plugins/helper/index.ts
Lines 69 to 71 in 492debf
And this might lead to some undefined behaviors, so I think the return type of
StoreFunction
in the helper should be changed toany
.Screenshots
Pull request tasks