Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#224 changed TypeUrl to TypeURL #235

Merged
merged 1 commit into from
May 26, 2019
Merged

#224 changed TypeUrl to TypeURL #235

merged 1 commit into from
May 26, 2019

Conversation

kigamittsu
Copy link
Contributor

fix #224

@codecov-io
Copy link

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   57.64%   57.64%           
=======================================
  Files           3        3           
  Lines         654      654           
=======================================
  Hits          377      377           
  Misses        219      219           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00da0c...646be22. Read the comment docs.

Copy link
Member

@slimsag slimsag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you & apologies for the delayed review :) Feel free to send a PR adding yourself to the https://github.com/gopherjs/vecty/blob/master/CONTRIBUTORS list if you like!

@slimsag slimsag merged commit 1733060 into hexops:master May 26, 2019
slimsag added a commit that referenced this pull request May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename prop.TypeUrl -> prop.TypeURL
3 participants