Updated $.fn.trigger() to make a special case for the submit event, w…

…here when triggered it doesn't fire any attached event handlers. It now uses a custom event to do this.
hexydec · Dec 19, 2018 · 6b908d3 · 6b908d3
1 parent f07dedf
commit 6b908d3
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 6 deletions.
diff --git a/dist/dabby.es5.js b/dist/dabby.es5.js
diff --git a/dist/dabby.es5.js.map b/dist/dabby.es5.js.map
diff --git a/dist/dabby.es5.min.js b/dist/dabby.es5.min.js
diff --git a/dist/dabby.js b/dist/dabby.js
@@ -1092,7 +1092,9 @@ $.fn.position = function () {
 $.fn.trigger = function (name, data) {
 	let i = this.length;
 	while (i--) {
-		if ($.isFunction(this[i][name])) {
+
+		// native submit event doesn't trigger event handlers
+		if (name !== "submit" && $.isFunction(this[i][name])) {
 			this[i][name]();
 		} else {
 			const evt = new CustomEvent(name, {bubbles: true, cancelable: true});

diff --git a/dist/dabby.min.js b/dist/dabby.min.js
diff --git a/src/events/trigger/trigger.js b/src/events/trigger/trigger.js
@@ -4,7 +4,9 @@ import "../../utils/isfunction/isfunction.js";
 $.fn.trigger = function (name, data) {
 	let i = this.length;
 	while (i--) {
-		if ($.isFunction(this[i][name])) {
+
+		// native submit event doesn't trigger event handlers
+		if (name !== "submit" && $.isFunction(this[i][name])) {
 			this[i][name]();
 		} else {
 			const evt = new CustomEvent(name, {bubbles: true, cancelable: true});