Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make TanStack Query plugin work with class-based services #1096

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Sep 26, 2024

Closes #1090

Copy link

stackblitz bot commented Sep 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review September 26, 2024 15:37
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: b6e350a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:46pm

Copy link

pkg-pr-new bot commented Sep 26, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1096
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1096
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1096

commit: b6e350a

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 18 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (867682d) to head (b6e350a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...napi-ts/src/plugins/@tanstack/query-core/plugin.ts 10.52% 17 Missing ⚠️
packages/openapi-ts/src/generate/transformers.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
- Coverage   81.21%   81.14%   -0.08%     
==========================================
  Files         102      102              
  Lines       11506    11540      +34     
  Branches     1232     1234       +2     
==========================================
+ Hits         9345     9364      +19     
- Misses       2158     2173      +15     
  Partials        3        3              
Flag Coverage Δ
unittests 81.14% <64.70%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit c43c949 into main Sep 26, 2024
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/tanstack-query-class-services branch September 26, 2024 15:53
@github-actions github-actions bot mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@tanstack/react-query is not compatible with asClass services
1 participant