Adding ServiceManager typescript definitions; and fixing typos and potential bugs. #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
index.js
params
parameter is optional, but if it wasn't sent thencustom
parameter value was being lost.limbotrans
for the property that was being populated by_processQuery
(x != null ? x : null) <==> x
undefined
nor other types (strings, objects, Dates, etc.), better using===
.options
is not defined, so these lines would throw an exception. Using null they will get their default values).infos.length
will never be defined asinfos
is meant to be an object with the required properties, so better using another validation for empty object.optread
as it was never usedcallback
parameter aspool
wasn't using it at all. The example in the README.md wasn't sending it as well.if
. No matter if it's true or false, the same code will be executedindex.d.ts
attach
to return aServiceManager
instancecallback
parameter frompool
.ServiceManager
definitions