Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definitions to transaction isolation modes #262

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Add definitions to transaction isolation modes #262

merged 1 commit into from
Aug 31, 2021

Conversation

Rafatcb
Copy link
Contributor

@Rafatcb Rafatcb commented Aug 29, 2021

These comments allow VSCode to show a definition for each transaction type when hovering them:

Transaction definition on tooltip

I copied the definition from the official docs, but it doesn't have the read-only definition. I imagine it could be something like:

A transaction sees only data committed before the statement has been executed and has no write permission.

But, as I'm not sure about this definition, I didn't create a comment for it. What do you think?


Also, I'd like to mention that ISOLATION_READ_COMMITED has a typo, it should be ISOLATION_READ_COMMITTED. Changing it would break the existing code, so I didn't change it in this PR.

@mariuz mariuz merged commit debe981 into hgourvest:master Aug 31, 2021
@Rafatcb Rafatcb deleted the patch-1 branch September 1, 2021 12:21
mariuz added a commit that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants