Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 2.7 support? #906

Closed
hgrecco opened this issue Dec 1, 2019 · 3 comments · Fixed by #908
Closed

Drop Python 2.7 support? #906

hgrecco opened this issue Dec 1, 2019 · 3 comments · Fixed by #908

Comments

@hgrecco
Copy link
Owner

hgrecco commented Dec 1, 2019

Dropping Python 2.7 support has popped up a few times recently. I would like to make a list of issues and PR, and arguments to drop (or keep). Furthermore, if we drop: what will be the minimum Python 3 version we will support?

Issues suggesting drop:
@jthielen
Copy link
Contributor

jthielen commented Dec 2, 2019

To follow many of the core packages in the scientific Python ecosystem, I would think following NEP 29 would be best (so, Python 3.6+ currently).

@crusaderky
Copy link
Contributor

crusaderky commented Dec 2, 2019 •
edited
Loading

At xarray we implemented NEP-29 and we're very happy with how many day-to-day problems it solves.
We've also implemented a 12 months window for pandas and scipy and a very aggressive 6 months window for everything else; so far (AFAIK) we have not received a single complaint.

Ref: http://xarray.pydata.org/en/stable/installing.html#minimum-dependency-versions

This was referenced Dec 2, 2019
Merged
Closed
@crusaderky
Copy link
Contributor

Closes #871

@crusaderky crusaderky mentioned this issue Dec 3, 2019
Merged
@bors bors bot closed this as completed in 5f89246 Dec 3, 2019
@bors bors bot closed this as completed in #908 Dec 3, 2019
@crusaderky crusaderky mentioned this issue Dec 3, 2019
Merged
@hgrecco hgrecco mentioned this issue Dec 4, 2019
Closed
bors bot added a commit that referenced this issue Dec 5, 2019
@bors @crusaderky
Merge #910
a9831b0 
910: The grand Python 2.7 cleanup r=hgrecco a=crusaderky

xref #906, #908 

Remove all Python 2.7 syntax from the codebase

Co-authored-by: Guido Imperiale <crusaderky@gmail.com>
@dopplershift dopplershift mentioned this issue Jan 8, 2020
Closed
openstack-gerrit pushed a commit to openstack/requirements that referenced this issue Jan 18, 2020
@amotoki
Cap Pint version for python 3.5 or older
7e31225 
Python <3.6 support was dropped in Pint 0.10 [1].
Pint in upper-constraints.txt was updated to 0.10 recently and it causes
a failure in the translation jobs which run with python 3.5 [2].
This commit caps Pint version to 0.9 for python 3.4 and 3.5.

[1] hgrecco/pint#906
[2] http://zuul.openstack.org/build/2ba794496679447a97537e82857eba0e

Change-Id: I605115b0c2f4ea7dcf147238e9f6234e92c7d7ca
openstack-gerrit pushed a commit to openstack/openstack that referenced this issue Jan 18, 2020
@openstack-gerrit
Update git submodules
9c8ea1e 
* Update requirements from branch 'master'
  - Merge "Cap Pint version for python 3.5 or older"
  - Cap Pint version for python 3.5 or older
    
    Python <3.6 support was dropped in Pint 0.10 [1].
    Pint in upper-constraints.txt was updated to 0.10 recently and it causes
    a failure in the translation jobs which run with python 3.5 [2].
    This commit caps Pint version to 0.9 for python 3.4 and 3.5.
    
    [1] hgrecco/pint#906
    [2] http://zuul.openstack.org/build/2ba794496679447a97537e82857eba0e
    
    Change-Id: I605115b0c2f4ea7dcf147238e9f6234e92c7d7ca
tanaypf9 pushed a commit to tanaypf9/pf9-requirements that referenced this issue May 20, 2024
@amotoki
Cap Pint version for python 3.5 or older
4a63f4e 
Python <3.6 support was dropped in Pint 0.10 [1].
Pint in upper-constraints.txt was updated to 0.10 recently and it causes
a failure in the translation jobs which run with python 3.5 [2].
This commit caps Pint version to 0.9 for python 3.4 and 3.5.

[1] hgrecco/pint#906
[2] http://zuul.openstack.org/build/2ba794496679447a97537e82857eba0e

Change-Id: I605115b0c2f4ea7dcf147238e9f6234e92c7d7ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply NEP-29; add Python 3.7/3.8 crusaderky/pint
3 participants
@hgrecco @jthielen @crusaderky