[Quantity] Show proper location of UnitStrippedWarning #907
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users are interested where in their code they triggered the warning and not the original underlying implementation throwing the warning. By setting the stacklevel accordingly, users see the line of their code, which strips the warning.
|
bors r+ |
|
Thanks! |
bors bot
added a commit
that referenced
this pull request
Dec 2, 2019
907: [Quantity] Show proper location of UnitStrippedWarning r=hgrecco a=marscher Users are interested where in their code they triggered the warning and not the original underlying implementation throwing the warning. By setting the stacklevel accordingly, users see the line of their code, which strips the warning. Co-authored-by: Martin K. Scherer <marscher@users.noreply.github.com>
Build succeeded |
|
You're welcome! That was the quickest merge in my GH history :) |
|
Sometimes the stars align! (An the PR was concise and well explained!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are interested where in their code they triggered the warning
and not the original underlying implementation throwing the warning.
By setting the stacklevel accordingly, users see the line of their code, which
strips the warning.