This repository has been archived by the owner on Jul 22, 2020. It is now read-only.
Bug - Issue 17 - Drop table failure #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #17
DROP TABLEstatements are failing for migrations against embedded Cassandra and Apache Cassandra 3.7 and earlier. The issue appears due to the way Cassandra handlesSELECT count(*)statements used to check whether a table exists in a keyspace.This fix updated the
SELECT (*)statement atSchemaVersionDAOto useSELECT *instead. Changes may be reverted when a new major release is available.## Pull Request (PR) Checklist ### Documentation - [x] Documentation in `README.md` or Wiki updated ### Code Review - [x] Self code review -- take another pass through the changes yourself - [x] Completed all relevant `TODO`s, or call them out in the PR comments ### Tests - [x] All tests passes