This repository has been archived by the owner on Jul 22, 2020. It is now read-only.
Chore - Unit Tests in KotlinTest #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhandoko
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Completes chore #28
Related tickets: #30
Converted JUnit tests to use KotlinTest test framework (which uses JUnit v4 engine in the underlying framework). The tests will need further refactoring, but the tasks will be in a separate
tickfuture release (perhaps0.12).However, there is an issue with
CassandraMigrationApiKIT.kt(refer to the related tickets above) and thus,CassandraMigrationApiIT.javais left as-is for now until a resolution is found.NOTE: Initially the tests are developed with Spek but was moved to KotlinTest due to Spek's dependencies with Java 1.8, contributing to build and test errors in Travis CI.
Pull Request (PR) Checklist
Documentation
README.mdor Wiki updatedCode Review
TODOs, or call them out in the PR commentsTests