Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banish hh ignore error from codegen #544

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Banish hh ignore error from codegen #544

wants to merge 13 commits into from

Commits on May 24, 2023

  1. Banish HH_IGNORE_ERROR from codegen 

    Codegen changes in the next commit.
    @lexidor
    lexidor committed May 24, 2023
    Configuration menu
    Copy the full SHA
    b9fa1bc View commit details
    Browse the repository at this point in the history

  2. Banish HH_IGNORE_ERROR from codegen, codegen parts.

    @lexidor
    lexidor committed May 24, 2023
    Configuration menu
    Copy the full SHA
    700fb79 View commit details
    Browse the repository at this point in the history

  3. Remove fixmes from hand rolled nodes 

    These aren't affected by the codegen changes.
    @lexidor
    lexidor committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0bd68c2 View commit details
    Browse the repository at this point in the history

  4. Remove fixmes on declarations 

    These are particularly likely to cause non-local bugs (in general).
By removing the `final` modifier, and sealing it empty, we can remove this directive.
    @lexidor
    lexidor committed May 24, 2023
    Configuration menu
    Copy the full SHA
    fa76f27 View commit details
    Browse the repository at this point in the history

  5. Replace type_structure with type_structure_for_alias 

    This functionality can be implemented with a well-typed Hack API now, yippee!
    @lexidor
    lexidor committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6df8483 View commit details
    Browse the repository at this point in the history

  6. A couple forced unsafe casts

    @lexidor
    lexidor committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0197893 View commit details
    Browse the repository at this point in the history

  7. Remove dead fixmes

    @lexidor
    lexidor committed May 24, 2023
    Configuration menu
    Copy the full SHA
    847502c View commit details
    Browse the repository at this point in the history

  8. Lint 'n test

    @lexidor
    lexidor committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e83c4e8 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2023

  1. Merge branch 'main' into banish-hh-ignore-error-from-codegen

    @lexidor
    lexidor committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    680174a View commit details
    Browse the repository at this point in the history

  2. Correct masked out file signatures

    @lexidor
    lexidor committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    0d92f35 View commit details
    Browse the repository at this point in the history

  3. Apply a suggested fix I left for myself on Github

    @lexidor
    lexidor committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    0d0a265 View commit details
    Browse the repository at this point in the history

  4. Remove unused local variable

    @lexidor
    lexidor committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    8b1692a View commit details
    Browse the repository at this point in the history

  5. Remove unused local variable once again

    @lexidor
    lexidor committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    57f46ab View commit details
    Browse the repository at this point in the history