This repository has been archived by the owner on Oct 1, 2023. It is now read-only.
[IO] fix offset out-of-bounds issue in memory handle #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
fredemmott
reviewed
Mar 19, 2021
fredemmott
suggested changes
Mar 19, 2021
azjezz
force-pushed
the
memory-handle-fix
branch
from
47c87f1
to
e779f5f
Compare
|
@fredemmott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
azjezz
force-pushed
the
memory-handle-fix
branch
from
e779f5f
to
d8beead
Compare
jthemphill
suggested changes
Mar 20, 2021
There was a problem hiding this comment.
Looks good to me, but it looks like expect(...)->toBeSame(...) is gone from our internal version of fbexpect 😕
expect(...)->toEqual(...) works the same way and just calls into expect(...)->toBeSame(...): https://github.com/hhvm/fbexpect/blob/master/src/ExpectObj.hack#L40
If you change those two calls in the test, everything else looks good though!
azjezz
force-pushed
the
memory-handle-fix
branch
from
d8beead
to
99f86a7
Compare
|
@fredemmott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@fredemmott merged this pull request in 4870776. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a test to reproduce the bug.