-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
move to built-in: remove all sources, keep tests
We need a new release that does not define the HSL, to allow easy compatibility with 4.108+, where it is built-in. Keep the tests for now to ensure/test compatibility.
- Loading branch information
1 parent
24837f9
commit 63a2495
Showing
58 changed files
with
17 additions
and
6,039 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,59 +1,5 @@ | ||
# Contributing to the Hack Standard Library | ||
We want to make contributing to this project as easy and transparent as | ||
possible. | ||
# Contributing | ||
|
||
## Feature Requests | ||
|
||
New features should be contributed to | ||
[the experimental repository](https://github.com/hhvm/hsl-experimental/) | ||
instead; if you believe an experimental feature is mature, please file an | ||
issue to request the relevant files be moved to this repository. | ||
|
||
## Our Development Process | ||
|
||
The source of truth for this library is an internal repository; we continuously | ||
sync changes out to GitHub using | ||
[FBShipIt](https://github.com/facebook/fbshipit), and test/apply pull requests | ||
against the repository after review. | ||
|
||
If a pull request passes the public tests but has internal issues, we will not | ||
be able to merge the pull request until the internal issues are fixed; depending | ||
on the scale of the problem, this can take a few weeks. | ||
|
||
## Pull Requests | ||
We actively welcome your pull requests. | ||
|
||
1. Fork the repo and create your branch from `master`. | ||
2. If you've added code that should be tested, add tests. | ||
3. If you've changed APIs, update the documentation. | ||
4. Ensure the test suite passes. | ||
5. Make sure your code lints. | ||
6. If you haven't already, complete the Contributor License Agreement ("CLA"). | ||
|
||
## Contributor License Agreement ("CLA") | ||
In order to accept your pull request, we need you to submit a CLA. You only need | ||
to do this once to work on any of Facebook's open source projects. | ||
|
||
Complete your CLA here: <https://code.facebook.com/cla> | ||
|
||
## Issues | ||
We use GitHub issues to track public bugs. Please ensure your description is | ||
clear and has sufficient instructions to be able to reproduce the issue. | ||
|
||
Facebook has a [bounty program](https://www.facebook.com/whitehat/) for the safe | ||
disclosure of security bugs. In those cases, please go through the process | ||
outlined on that page and do not file a public issue. | ||
|
||
## Coding Style | ||
|
||
* 2 spaces for indentation rather than tabs | ||
* 80 character line length | ||
* Be consistent with existing code | ||
* Be consistent with hackfmt | ||
|
||
We do not follow the PSR guidelines. | ||
|
||
## License | ||
By contributing to the Hack Standard Library, you agree that your contributions | ||
will be licensed under the LICENSE file in the root directory of this source | ||
tree. | ||
As of 2021-05-04, the HSL is in the process of becoming built-in to the HSL; | ||
for now, contributions should be made to the `hphp/hsl` subdirectory of | ||
[the HHVM repository](https://github.com/facebook/hhvm/). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,6 @@ | |
"hhvm/hsl-experimental": "^4.37|dev-master" | ||
}, | ||
"require": { | ||
"hhvm": "^4.94" | ||
"hhvm": "^4.108" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"roots": [ | ||
"src/" | ||
"tests/" | ||
], | ||
"devRoots": [ | ||
"tests/" | ||
|
Empty file.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.