Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mysql): 添加ddl_dml不能同时提交的逻辑 #2060

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

summingyu
Copy link
Contributor

  1. common/templates/config.html: 新增一个配置项ddl_dml_separation, 默认为False, 如果开启, 则不允许DDL语句和DML语句同时执行
  2. sql/engines/mysql.py: 增加判断一个sql上线工单中,如果开启ddl_dml_separation, 并且同时存在ddl和dml,则error_count + 1

开启功能之后:

image

image

image

image

image

关闭功能之后:

image

image

Signed-off-by: summing.yu <summing.yu@huamengtech.net>
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 75.03% // Head: 75.00% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (deaa8af) compared to base (0eee241).
Patch coverage: 36.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2060      +/-   ##
==========================================
- Coverage   75.03%   75.00%   -0.03%     
==========================================
  Files         102      102              
  Lines       14809    14820      +11     
==========================================
+ Hits        11112    11116       +4     
- Misses       3697     3704       +7     
Impacted Files Coverage Δ
sql/engines/mysql.py 78.17% <36.36%> (-1.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: summingyu <summingbest@gmail.com>
@hhyo hhyo merged commit 0b0167f into hhyo:master Feb 25, 2023
@summingyu summingyu deleted the feature/ddl-dml-separation branch February 27, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants