-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
添加单元测试:自动审核逻辑中,测试auto_review_regex未配置时使用默认正则表达式的情况 #2583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
个人认为这件事情可能这样测更方便:
现在的设计,整个流程测有点太长了,而且不明显,建议你在测试时,就显式设定一些配置,仅对正则匹配进行校验 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2583 +/- ##
==========================================
+ Coverage 76.90% 76.91% +0.01%
==========================================
Files 117 117
Lines 16109 16120 +11
==========================================
+ Hits 12388 12399 +11
Misses 3721 3721 ☔ View full report in Codecov by Sentry. |
LeoQuote
reviewed
Apr 12, 2024
LeoQuote
approved these changes
Apr 12, 2024
LeoQuote
force-pushed
the
default_regex_auto_test
branch
from
April 12, 2024 11:11
b968b26
to
6ba6a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo