Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in helm charts values #894

Merged
merged 4 commits into from
Sep 29, 2020
Merged

fix: typo in helm charts values #894

merged 4 commits into from
Sep 29, 2020

Conversation

exqlnet
Copy link
Contributor

@exqlnet exqlnet commented Sep 27, 2020

No description provided.

@request-info
Copy link

request-info bot commented Sep 27, 2020

你好!感谢你反馈的问题/bug,但是你的描述好像是空的,我们需要你完整的信息,这样才能帮你解决问题 如果不知道怎么写,在新建issue的时候有若干个模板可供选择,祝好!

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #894 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   78.27%   78.27%           
=======================================
  Files          77       77           
  Lines       11030    11030           
=======================================
  Hits         8634     8634           
  Misses       2396     2396           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737c70c...86178df. Read the comment docs.

@LeoQuote
Copy link
Collaborator

你改过的也是错的 是 subcharts

@LeoQuote
Copy link
Collaborator

哎哟,还是家园网的,校友啊

@exqlnet
Copy link
Contributor Author

exqlnet commented Sep 28, 2020

哎哟,还是家园网的,校友啊

嘿嘿,看来是学长啊,好巧哈哈哈
是我粗心了,昨晚梦游来找开源项目 😁

@LeoQuote LeoQuote changed the title fix: typo fix: typo in helm charts values Sep 28, 2020
LeoQuote
LeoQuote previously approved these changes Sep 28, 2020
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LeoQuote
Copy link
Collaborator

@hhyo 感觉 travis 是不是要凉啊这个build 又没启动

@LeoQuote
Copy link
Collaborator

LeoQuote commented Sep 28, 2020

@hhyo 好像 travis 不用 github status 这个接口了,有空给这个项目安一下这个 app https://github.com/marketplace/travis-ci https://blog.travis-ci.com/2018-09-27-deprecating-github-commit-status-api-for-github-apps-managed-repositories

@hhyo
Copy link
Owner

hhyo commented Sep 28, 2020

装好了,看来可以考虑改成action了

@LeoQuote
Copy link
Collaborator

在travis上重跑下这个pr看看会不会有check

hhyo
hhyo previously approved these changes Sep 28, 2020
@hhyo hhyo merged commit 20462a1 into hhyo:master Sep 29, 2020
@LeoQuote
Copy link
Collaborator

有check 了 @hhyo 另外下次😅 squash and merge 吧, 把我的那个没什么用的commit 都带进去了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants