Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-18489 Lazy, unowned one-to-one associations get loaded eagerly in queries - even with bytecode enhancement #8812

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dreab8
Copy link
Contributor

@dreab8 dreab8 commented Aug 21, 2024


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18489


final Set<String> initializedLazyAttributeNames = interceptor.getInitializedLazyAttributeNames();
final Set<String> initializedLazyAttributeNames = interceptor.getInitializedLazyAttributeNames();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
PersistentAttributeInterceptor.getInitializedLazyAttributeNames
should be avoided because it has been deprecated.
);
if ( set ) {
result = selectedValue;
interceptor.attributeInitialized( fetchGroupAttributeDescriptor.getName() );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
PersistentAttributeInterceptor.attributeInitialized
should be avoided because it has been deprecated.
@dreab8 dreab8 marked this pull request as ready for review August 22, 2024 12:13
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM as long as this passes the test, but I noticed what could be a bug; see below.

@dreab8 dreab8 force-pushed the HHH-18489_2 branch 2 times, most recently from 46c3dbc to 3f8e726 Compare September 3, 2024 08:40
@dreab8
Copy link
Contributor Author

dreab8 commented Sep 12, 2024

@yrodiere I applied your suggestions. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants