Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-16789 Improve error message for use of limit without order by in subquery #9665

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mehmetali2003
Copy link


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-16789

Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like improving error messages, but I don't think this is the right way to do this.

It would be better to change the grammar (HqlParser.g4) to accept limit with no order by, and then detect that and report this error from SemanticQueryBuilder.

This comes back to the thing I've often talked about: it's better to make the parser quite forgiving, accepting more things than what are actually legal in the language, and then detect illegal things later, where we can easily report more meaningful errors. The reason is that generated parsers typically report syntax errors in a way that's not very helpful to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants