Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBX-2951: Backport automated releases to branch 6.6 #4972

Merged
merged 1 commit into from
Jan 15, 2025
Merged

HBX-2951: Backport automated releases to branch 6.6 #4972

merged 1 commit into from
Jan 15, 2025

Conversation

koentsje
Copy link
Member

@koentsje koentsje commented Jan 15, 2025 •
edited
Loading

  • Add 'build' section with execution of 'maven-wrapper-plugin'
  • Add generated Maven wrapper
  • Use Maven wrapper in '.github/workflows/build_test.yml'

@koentsje koentsje force-pushed the HBX-2951 branch 2 times, most recently from 3c4223f to 8978d47 Compare January 15, 2025 13:53
@marko-bekhta
Copy link
Member

marko-bekhta commented Jan 15, 2025 •
edited
Loading

I think you would also need to run:

mvn wrapper:wrapper

and include the generated files 🙈 : 347f246

and probably this one too 0b4a0ea. That way we wouldn't need to update the Version class ...

@koentsje
HBX-2951: Backport automated releases to branch 6.6
48a180b 
  - Add 'build' section with execution of 'maven-wrapper-plugin'
  - Add generated Maven wrapper
  - Use Maven wrapper in '.github/workflows/build_test.yml'

Signed-off-by: Koen Aers <koen.aers@gmail.com>
@koentsje
Copy link
Member Author

I think you would also need to run:

mvn wrapper:wrapper

and include the generated files 🙈 : 347f246

and probably this one too 0b4a0ea. That way we wouldn't need to update the Version class ...

indeed, I am learning the hard way 🙄

@koentsje koentsje merged commit 48a180b into hibernate:6.6 Jan 15, 2025
3 checks passed
@koentsje koentsje deleted the HBX-2951 branch January 15, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koentsje @marko-bekhta