Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBX-2956 Use SHA in github actions workflow #4983

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marko-bekhta
Copy link
Member

https://hibernate.atlassian.net/browse/HBX-2956

I'm not sure about the GabrielBB/xvfb-action since it seems that this one is for running some selenium tests, but I don't think we have those in the repository? (or was there some other reason to install XVFB.. )

@koentsje
Copy link
Member

koentsje commented Feb 5, 2025

https://hibernate.atlassian.net/browse/HBX-2956

I'm not sure about the GabrielBB/xvfb-action since it seems that this one is for running some selenium tests, but I don't think we have those in the repository? (or was there some other reason to install XVFB.. )

This was used to test the StatisticsBrowser, but this test has been disabled for a long time now:

Not sure if anyone uses this Browser actually...

@marko-bekhta marko-bekhta force-pushed the build/HBX-2956-Use-SHA-in-github-actions-workflow branch from 9507f93 to 14532db Compare February 5, 2025 09:49
@marko-bekhta
Copy link
Member Author

Got it 😃, so let's keep it for now, then... maybe the test will get re-enabled at some point 🤞🏻 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants