HV-1831 experiments (6.2) #1170
Closed
+2,432
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for containers; add tests for List w/ and w/o duplicated values
Add test for Map
…or with -p=predefined=true
…tracking is not required
I removed it from the traditional VF for now as I would like us to focus on the case where it is useful first. We will reintroduce it later once we have validated the approach where it is the most useful. I'm a bit unclear right now if we should use the same contract for traditional and predefined scope VF as we are dealing with different things and they won't be evaluated at the same moment. I'm thinking that maybe this needs to be a different contract.
gbadner
commented
Jul 30, 2021
| } | ||
| final BeanMetaData<?> beanMetaData = rawBeanMetaDataMap.get( beanClass ); | ||
|
|
||
| if ( beanMetaData == null || !beanMetaData.hasCascadables() ) { |
There was a problem hiding this comment.
I was wondering how to deal with beanMetaData == null. I'm glad to see that spelled out here.
|
@gsmet, I've read through your changes, and I understand why you made those changes. Looks good to me! |
This contract allows to override the default bean process tracking behavior without exposing our internal structures. It needs a bit more love on the config side so that we can define it via XML too and some documentation.
|
Has this stalled? Any chance we will see a resolution to this in a near release? |
|
I recreated the PR with a branch in my fork here: #1288 . |
|
@jameswynn I don't have much time to spend on HV lately. If someone is interested in pursuing this in the meantime, it's very welcome. |
|
@gsmet : we have similar issues with the current solution. I'm having troubles finding the latest status of this. Is somebody still working on this? Thanks.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HV-1831
Supersedes #1169, which targets the incorrect branch.