Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HV-1989 Update documentation examples to use the min required Java version where applicable #1362

Conversation

marko-bekhta
Copy link
Member

@marko-bekhta marko-bekhta commented Jun 20, 2024

@marko-bekhta marko-bekhta force-pushed the docs/HV-1989-Update-docuemntation-examples-to-use-Java-11-where-applicable branch from 44d71dc to ca64d54 Compare June 20, 2024 11:24
cdi/pom.xml Outdated Show resolved Hide resolved
@@ -20,7 +20,7 @@ The full list of changes for this release can be found in changelog.txt.

## System Requirements

JDK 8 or above.
JDK 17 or above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says Java 11... ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump :) PR description is okay now, but not the backport, nor the Jira issue 🙈

documentation/src/main/asciidoc/ch02.asciidoc Show resolved Hide resolved
engine/pom.xml Outdated Show resolved Hide resolved
documentation/src/main/asciidoc/ch01.asciidoc Outdated Show resolved Hide resolved
@marko-bekhta marko-bekhta changed the title HV-1989 Update documentation examples to use Java 11 where applicable HV-1989 Update documentation examples to use the min required Java version where applicable Jul 9, 2024
@marko-bekhta marko-bekhta force-pushed the docs/HV-1989-Update-docuemntation-examples-to-use-Java-11-where-applicable branch from fa59b9a to b7632c7 Compare July 9, 2024 14:05
engine/pom.xml Outdated Show resolved Hide resolved
performance/pom.xml Show resolved Hide resolved
@@ -20,7 +20,7 @@ The full list of changes for this release can be found in changelog.txt.

## System Requirements

JDK 8 or above.
JDK 17 or above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump :) PR description is okay now, but not the backport, nor the Jira issue 🙈

@marko-bekhta marko-bekhta force-pushed the docs/HV-1989-Update-docuemntation-examples-to-use-Java-11-where-applicable branch from b7632c7 to 9d8ded6 Compare July 15, 2024 14:53
@marko-bekhta marko-bekhta force-pushed the docs/HV-1989-Update-docuemntation-examples-to-use-Java-11-where-applicable branch from 9d8ded6 to d7e1a1a Compare July 15, 2024 14:56
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jul 15, 2024

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@marko-bekhta marko-bekhta merged commit a6a780f into hibernate:main Jul 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants