Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of HV-1989 to 8.0 - Update documentation examples to use the min required Java version where applicable #1363

Merged
merged 4 commits into from
Jul 20, 2024
Merged

Backport of HV-1989 to 8.0 - Update documentation examples to use the min required Java version where applicable #1363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97d66b2
HV-1989 Remove unused property
marko-bekhta Jun 20, 2024
0a8e96d
HV-1989 Update documentation examples to use Java 11 where applicable
marko-bekhta Jun 20, 2024
3b77a88
HV-1989 Update Readme to mention Java 11
marko-bekhta Jun 20, 2024
fe0f697
HV-1989 Fix spec version in the CDI extension manifest
marko-bekhta Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The full list of changes for this release can be found in changelog.txt.

## System Requirements

JDK 8 or above.
JDK 11 or above.

## Using Hibernate Validator

Expand Down
2 changes: 1 addition & 1 deletion cdi/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
<manifestEntries>
<Specification-Title>Jakarta Bean Validation</Specification-Title>
<Specification-Version>2.0</Specification-Version>
<Specification-Version>3.0</Specification-Version>
<Automatic-Module-Name>${hibernate-validator-cdi.module-name}</Automatic-Module-Name>
</manifestEntries>
</archive>
Expand Down
4 changes: 3 additions & 1 deletion documentation/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,12 +289,14 @@
<bvVersion>${version.jakarta.validation-api}</bvVersion>
<jbossLoggingVersion>${version.org.jboss.logging.jboss-logging}</jbossLoggingVersion>
<classmateVersion>${version.com.fasterxml.classmate}</classmateVersion>
<jakartaElVersion>${version.org.glassfish.jakarta.el}</jakartaElVersion>
<expresslyVersion>${version.org.glassfish.expressly}</expresslyVersion>

<wildflyVersion>${version.wildfly}</wildflyVersion>
<wildflySecondaryVersion>${version.wildfly.secondary}</wildflySecondaryVersion>

<jdkVersion>${java-version.main.release}</jdkVersion>
<compilerPluginVersion>${version.compiler.plugin}</compilerPluginVersion>

<!-- URLs -->
<javaApiDocsUrl>${java.api-docs.base-url}/</javaApiDocsUrl>
<bvApiDocsUrl>${bv.api-docs.base-url}/</bvApiDocsUrl>
Expand Down
6 changes: 3 additions & 3 deletions documentation/src/main/asciidoc/ch01.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,10 @@ $JBOSS_HOME/bin/jboss-cli.sh patch rollback --reset-configuration=true

You can learn more about the WildFly patching infrastructure in general https://developer.jboss.org/wiki/SingleInstallationPatching/[here] and http://www.mastertheboss.com/jboss-server/jboss-configuration/managing-wildfly-and-eap-patches[here].

[[validator-gettingstarted-java9]]
==== Running on Java 11+
[[validator-gettingstarted-modulepath]]
==== [[validator-gettingstarted-java9]] Running in the modulepath

Support for Java 11 and the Java Platform Module System (JPMS) is present in a preliminary form.
Support for the Java Platform Module System (JPMS) is present in a preliminary form.
There are no JPMS module descriptors provided, but Hibernate Validator is usable as automatic modules.

These are the module names as declared using the `Automatic-Module-Name` header:
Expand Down
8 changes: 4 additions & 4 deletions documentation/src/main/asciidoc/ch13.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ For using the Hibernate Validator annotation processor with Maven, set it up via
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.6.1</version>
<version>{compilerPluginVersion}</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
<source>{jdkVersion}</source>
<target>{jdkVersion}</target>
<annotationProcessorPaths>
<path>
<groupId>org.hibernate.validator</groupId>
Expand Down Expand Up @@ -185,7 +185,7 @@ provided you have the https://www.eclipse.org/m2e/[M2E Eclipse plug-in] installe
For plain Eclipse projects follow these steps to set up the annotation processor:

* Right-click your project, choose "Properties"
* Go to "Java Compiler" and make sure, that "Compiler compliance level" is set to "1.8".
* Go to "Java Compiler" and make sure, that "Compiler compliance level" is set to "{jdkVersion}".
Otherwise the processor won't be activated
* Go to "Java Compiler - Annotation Processing" and choose "Enable annotation processing"
* Go to "Java Compiler - Annotation Processing - Factory Path" and add the JAR
Expand Down