Introduce a PathBuilder #850
Commits on Sep 18, 2017
-
HV-1480 Add a hv-6.0 entry to be able to compare the latest stable with
our current snapshot
-
HV-1480 Avoid removing and adding element to the node list
We can directly set the element in the list. It avoids some list resizing.
-
-
HV-1480 Avoid initializing lists and maps in the common case where we
only have the default group Also optimize a bit the advanced case with groups.
-
HV-1480 Avoid creating a list in the common case when we only have the
default violation Also optimize a bit the concatenation of the default violation and the custom ones to avoid creating a list too small and resize it each time.
-
HV-1480 Avoid computing the hashCode if not necessary
A lot of NodeImpls are created during the build of the path and some of them are simply discarded as they are "modified" (NodeImpl are immutable so we create a new) further away. Thus we better avoid building the hashCode each time.
-
HV-1480 Don't take into account the parent in hashCode and equals
Otherwise, we "compare" the whole path several times while comparing a path.
-
HV-1480 Implement a copy on write strategy for the node list
It avoids copying the list when not strictly necessary
-
HV-1480 Centralize the processed works in one single set
It avoids a lot of initialization/resizing and in the end it's more efficient.
-
HV-1480 Setting the key or the index already makes the node iterable
So we don't need to do it twice. Note that this change uncovers the fact that in ConstraintValidatorContext, calling atKey() or atIndex() makes the node iterable. It was already the case before and I think it's acceptable. It brings its own performance improvements as it avoids initializing 1 NodeImpl and creating 1 copy of the Path.
-
HV-1480 We expect at least one node in the path so let's initialize the
list with one element It doesn't seem necessary to consider more elements as the list will be copied when new nodes will be added.
-
HV-1480 Even if not strictly necessary, the leaf node should be
correctly set in all constructors
-
-
-
-
-
HV-1480 Only set the property value if required
Only property and container node exposes it to users.
-
-
