Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dash): Add --insecure option #980

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

robinjoseph08
Copy link
Contributor

This adds the flag --insecure to asynq dash that works just like the --insecure flag on the redis-cli where it doesn't validate the TLS config. This is necessary to be able to connect to some Redis servers that are fronted by a self-signed certificate. This can either be self-hosted or hosted by some providers like Heroku.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.32%. Comparing base (4f00f52) to head (e4eb794).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
- Coverage   67.13%   66.32%   -0.82%     
==========================================
  Files          29       29              
  Lines        4300     5740    +1440     
==========================================
+ Hits         2887     3807     +920     
- Misses       1135     1652     +517     
- Partials      278      281       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamikazechaser kamikazechaser merged commit 0290755 into hibiken:master Dec 9, 2024
8 of 9 checks passed
divyam234 pushed a commit to divyam234/asynq that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants