New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing variable: loading #234

Open

humanshado wants to merge 1 commit into hibiken:master from humanshado:master

humanshado commented Aug 22, 2018

Before submitting a pull request, please make sure the following is done...

Fork the repo and create your branch from master.
If you've added code that should be tested, add tests!
If you've changed APIs, update the documentation.
Ensure that:

The test suite passes (npm test)
Write formatted git commits by using npm run commit

Please use the simple form below as a guideline for describing your pull request.

Thanks for contributing!

Summary

[...]


          add missing variable: loading

d2e5b24

Author

humanshado commented Aug 22, 2018

Noticed a missing variable "loading" in the readme doc, line 188.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet