Remove double-navigate on startup #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InitializeOverlay() method in OverlayBase will Navigate to the Config.Url to be loaded. Then it also sets a timer for 1s later to again Navigate to Config.Url. This has the effect of loading everything twice, which is more work, and causing everything to flash about 1 second after starting.
quisquous
pushed a commit
to quisquous/OverlayPlugin
that referenced
this pull request
Nov 6, 2019
Fully Chinese translation.
quisquous
added a commit
to quisquous/OverlayPlugin
that referenced
this pull request
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a flash on startup along with wasted work doing everything an extra time, as described in the commit message.