-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix - Fix property names on SVG #1331
Open
TezzardzGoneWild
wants to merge
3,739
commits into
hicetnunc2000:main
Choose a base branch
from
TezzardzGoneWild:bugfix/fix-svg-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bugfix - Fix property names on SVG #1331
TezzardzGoneWild
wants to merge
3,739
commits into
hicetnunc2000:main
from
TezzardzGoneWild:bugfix/fix-svg-errors
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacked account shutdown for megachel
not sure about that one
…event-back-button-loop Bugfix - Prevent back button loop on Artist / Collector pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the SVGs had multiple properties using dashes instead of camelCase (ex.
stroke-width
instead ofstrokeWidth
). React doesn't read / apply these properly and will throw errors in the console.Similarly, React requires
className
to be used instead ofclass